Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added files for docker support #4

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

jsoika
Copy link
Contributor

@jsoika jsoika commented Sep 25, 2023

I'm running only containers on my local server and thought it could be helpful for someone else to have support for docker images on this cool project.

I've added a dockerfile, a docker-compose.yaml and updated the documentation. What is missing is a build and publish step for the docker images to Docker Hub container registry. Right now the image needs to be build locally.

@scosman
Copy link
Owner

scosman commented Sep 26, 2023

This is great! Thanks for the contribution.

Will merge as is. If you want to add the auto-building and publishing, I've done that before for Go projects and it's pretty easy. Here's a template you can borrow from: https://github.com/scosman/zipstreamer/blob/master/.github/workflows/publish.yml

@scosman scosman merged commit dc8a800 into scosman:main Sep 26, 2023
@scosman
Copy link
Owner

scosman commented Sep 26, 2023

Also: adding Home Assistant docs is really good call 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants