Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to turn off setup of shell completion #342

Merged

Conversation

mmcrockett
Copy link
Contributor

Issue

  • When I moved from Linux => Mac I didn't have bash completion package installed and so got these errors (plus turns out I really prefer to complete on filenames even though the branch complete is a nice feature)

Screenshot of errors I see:
Screenshot 2024-12-11 at 1 32 14 PM

Proposed Fix

  • Add an option git_skip_shell_completion that is backward compatible and will ignore any shell completion setup

@mmcrockett mmcrockett changed the title mcrockett/Add option to turn off setup of shell completion Add option to turn off setup of shell completion Dec 11, 2024
@mmcrockett mmcrockett changed the title Add option to turn off setup of shell completion feat: Add option to turn off setup of shell completion Dec 11, 2024
ghthor
ghthor previously approved these changes Dec 13, 2024
lib/git/aliases.sh Outdated Show resolved Hide resolved
@mmcrockett
Copy link
Contributor Author

I had considered moving all shell completion to one spot but couldn't decide if that was better/worse than having the completion near the function (ie complete for branch is in lib/git/branch_shortcuts.sh. If that would help the code organization, let me know and I can do a follow-up PR.

@ghthor
Copy link
Member

ghthor commented Dec 13, 2024

I had considered moving all shell completion to one spot but couldn't decide if that was better/worse than having the completion near the function (ie complete for branch is in lib/git/branch_shortcuts.sh. If that would help the code organization, let me know and I can do a follow-up PR.

I like this idea, 👍 from me

@ghthor ghthor merged commit fa18af9 into scmbreeze:master Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants