-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed completions for 'gl' and 'gla' aliases #319
Conversation
This changes the argument definition from a single string into an array of strings? That seems fine to me. |
Right, because __git_alias function defined above in that file expects the argument list split into array:
|
Hi, |
Would sure be nice to have this merge in! |
No, I've just been lazy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to make a test for this, but did test these changes locally
.scm_breeze/test (dac7e1e) [?]
❯ source ~/.scm_breeze/scm_breeze.sh
Tue Feb 27 06:11:40 2024 exit 0 🟢 took 29s
.scm_breeze/test (dac7e1e) [?]
❯ type gl
gl is aliased to `git log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit'
Tue Feb 27 06:11:44 2024 exit 0 🟢
.scm_breeze/test (dac7e1e) [?]
❯ type gla
gla is aliased to `git log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit --branches --remotes'
.scm_breeze/test (dac7e1e) [?]
❯ gla -n2
* dac7e1e - (HEAD, scm_breeze/pr/319) Merge branch 'master' into master (6 minutes ago) <Will Owens>
|\
| * b2b666b - (scm_breeze/master) Merge pull request #333 from ghthor/switch-to-github-actions (13 minutes ago) <Will Owens>
| |\
.scm_breeze/test (dac7e1e) [?]
❯ gl -10 HEAD^
* a430817 - Fixed completions for 'gl' and 'gla' aliases (1 year, 4 months ago) <telzhov>
Thanks a lot! |
Closes #320