Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications work when forum updates #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

knaou
Copy link

@knaou knaou commented Mar 17, 2018

  • Add a option to enable forum updating notification
  • Add hook to post message of update of forum message (parent message and replied message)

Tested on Redmine 3.3.4.stable

Copy link
Contributor

@cat-in-136 cat-in-136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found trivial "escape" mistakes. This PR works fine. 👍


user = message.author
project_url = "<#{object_url project}|#{escape project}>"
message_url = "<#{object_url message}|#{message.subject}>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lacking escape : escape message.subject


user = message.author
project_url = "<#{object_url project}|#{escape project}>"
message_url = "<#{object_url message}|#{message.subject}>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lacking escape : escape message.subject

@knaou
Copy link
Author

knaou commented Jun 18, 2018

@cat-in-136 Thank you for your review. The pull was updated.

cat-in-136 added a commit to cat-in-136/redmine-slack that referenced this pull request Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants