chore: [pre-commit.ci] pre-commit autoupdate

[pre-commit-ci]

updates:

• github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0
• github.com/astral-sh/ruff-pre-commit: v0.5.0 → v0.6.9
• github.com/psf/black-pre-commit-mirror: 24.4.2 → 24.10.0
• github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.2
• github.com/python-jsonschema/check-jsonschema: 0.28.6 → 0.29.3

* Update pre-commit hooks:
   - github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0
   - github.com/astral-sh/ruff-pre-commit: v0.5.0 → v0.6.9
   - github.com/psf/black-pre-commit-mirror: 24.4.2 → 24.10.0
   - github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.2
   - github.com/python-jsonschema/check-jsonschema: 0.28.6 → 0.29.3

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (3d26434) to head (189be40).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2535   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           

Flag	Coverage Δ
contrib	97.79% <ø> (ø)
doctest	98.08% <ø> (ø)
unittests-3.10	96.23% <ø> (ø)
unittests-3.11	96.23% <ø> (ø)
unittests-3.12	96.23% <ø> (ø)
unittests-3.8	96.25% <ø> (ø)
unittests-3.9	96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matthewfeickert]

pre-commit is failing on mypy now with

mypy with Python 3.8.....................................................Failed
- hook id: mypy
- exit code: 1

src/pyhf/tensor/numpy_backend.py:38: error: Argument 2 to "poisson_logpdf" of "numpy_backend" has incompatible type "Union[ndarray[Any, dtype[number[T@__init__]]], ndarray[Any, dtype[bool]]]"; expected "Union[ndarray[Any, dtype[number[T@log_prob]]], ndarray[Any, dtype[bool]]]"  [arg-type]
src/pyhf/tensor/numpy_backend.py:51: error: Argument 2 to "normal_logpdf" of "numpy_backend" has incompatible type "Union[ndarray[Any, dtype[number[T@__init__]]], ndarray[Any, dtype[bool]]]"; expected "Union[ndarray[Any, dtype[number[T@log_prob]]], ndarray[Any, dtype[bool]]]"  [arg-type]
src/pyhf/tensor/numpy_backend.py:51: error: Argument 3 to "normal_logpdf" of "numpy_backend" has incompatible type "Union[ndarray[Any, dtype[number[T@__init__]]], ndarray[Any, dtype[bool]]]"; expected "Union[ndarray[Any, dtype[number[T@log_prob]]], ndarray[Any, dtype[bool]]]"  [arg-type]
Found 3 errors in 1 file (checked 72 source files)

mypy with Python 3.12....................................................Failed
- hook id: mypy
- exit code: 1

src/pyhf/tensor/numpy_backend.py:38: error: Argument 2 to "poisson_logpdf" of "numpy_backend" has incompatible type "ndarray[Any, dtype[number[T@__init__]]] | ndarray[Any, dtype[bool]]"; expected "ndarray[Any, dtype[number[T@log_prob]]] | ndarray[Any, dtype[bool]]"  [arg-type]
src/pyhf/tensor/numpy_backend.py:51: error: Argument 2 to "normal_logpdf" of "numpy_backend" has incompatible type "ndarray[Any, dtype[number[T@__init__]]] | ndarray[Any, dtype[bool]]"; expected "ndarray[Any, dtype[number[T@log_prob]]] | ndarray[Any, dtype[bool]]"  [arg-type]
src/pyhf/tensor/numpy_backend.py:51: error: Argument 3 to "normal_logpdf" of "numpy_backend" has incompatible type "ndarray[Any, dtype[number[T@__init__]]] | ndarray[Any, dtype[bool]]"; expected "ndarray[Any, dtype[number[T@log_prob]]] | ndarray[Any, dtype[bool]]"  [arg-type]
Found 3 errors in 1 file (checked 72 source files)

[kratsg]

Looks like there's a slightly different type coercion needed here (taking one as an example0

src/pyhf/tensor/numpy_backend.py:38: error: Argument 2 to "poisson_logpdf" of "numpy_backend" has incompatible type

got:
"Union[ndarray[Any, dtype[number[T@__init__]]], ndarray[Any, dtype[bool]]]"

expected:
"Union[ndarray[Any, dtype[number[T@log_prob]]], ndarray[Any, dtype[bool]]]"

so need to dig into why. The @ notation is throwing me off a little (must be related to the generics). /cc @henryiii or @alexander-held if they've seen this before.

with this code

class _BasicPoisson:
    def __init__(self, rate: Tensor[T]):
        self.rate = rate

    def sample(self, sample_shape: Shape) -> ArrayLike:
        return poisson(self.rate).rvs(size=sample_shape + self.rate.shape)  # type: ignore[no-any-return]

    def log_prob(self, value: NDArray[np.number[T]]) -> ArrayLike:
        tensorlib: numpy_backend[T] = numpy_backend()
        return tensorlib.poisson_logpdf(value, self.rate)

here, it seems to complain about self.rate which is typed as Tensor[T].

[matthewfeickert]

I'm going to merge this even though the CI is broken, as the other components are fine. We can follow up in #2553.