-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Remove transient directories after install to allow for rebuild #311
build: Remove transient directories after install to allow for rebuild #311
Conversation
261759f
to
6004f24
Compare
This is ready for review. The CI build wheels jobs are broken in general given Lines 16 to 23 in f90dc72
is hitting
but that can get fixed in another PR. For this PR what matters is that I can now do
without erroring out. |
cc @kawaho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is everything that's needed, but directories named "build" and "_*" are the sorts of things that should be cleaned up.
You should also get a review from someone who is more qualified to verify it.
* While doing multiple rebuilds it is advisable to also clean up the state of the Git submodules with 'git clean -f', removing the OUTPUT directory at src/fastjet/_fastjet_core/ and the top level build directory is sufficient to do local development rebuilds --- i.e., the command 'python -m pip install --upgrade .' can be run twice in a row without error.
6004f24
to
f05e28d
Compare
@rkansal47 unless you have any thoughts here I'm going to merge this at the end of the day to make @kawaho's development experience easier on PR #312. |
Thanks @matthewfeickert! Does this resolve #140? (Sorry, I'm not able to test the re-build myself currently.) EDIT: Looks like it should, so LGTM! |
Ah good catch @rkansal47! I hadn't even noticed Issue #140 while thinking on Issue #279. |
While doing multiple rebuilds it is advisable to also clean up the state of the Git submodules with
git clean -f
, removing theOUTPUT
directory atsrc/fastjet/_fastjet_core/
and the top level build directory is sufficient to do local development rebuilds — i.e., the commandpython -m pip install --upgrade .
can be run twice in a row without error.