Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EvtGen model HypNonLepton #440

Merged
merged 2 commits into from
May 29, 2024

Conversation

eduardo-rodrigues
Copy link
Member

FYI @sognetic, with this update all Belle II files in the current version of basf2 are parsed with no issues aside the one file 1263700001.dec, which contains the line
0.5 anti-D*0 mu+ nu_mu PHOTOS PHOTOS HQET3 0.912 1.205 1.15 1.404 0.854; #18.09.2018: updated to main DECAY_BELLE2.DEC
and DecayLanguage does not allow for twice the keyword PHOTOS in a decay line - not a bug per se but I would say a buglet. Maybe worth fixing upstream.

@eduardo-rodrigues eduardo-rodrigues added the enhancement New feature or request label May 29, 2024
@eduardo-rodrigues eduardo-rodrigues self-assigned this May 29, 2024
@eduardo-rodrigues eduardo-rodrigues merged commit 1c74d3b into master May 29, 2024
12 checks passed
@eduardo-rodrigues eduardo-rodrigues deleted the eduardo-add-new-belle2-model branch May 29, 2024 08:18
@sognetic
Copy link
Contributor

Hi @eduardo-rodrigues , thanks for the notification! I don't have access to upstream anymore but let me ping @GiacomoXT

@GiacomoXT
Copy link

@eduardo-rodrigues thanks for having spotted it! Indeed having the keyword PHOTOS twice is useless, I will fix it upstream in basf2.

@eduardo-rodrigues
Copy link
Member Author

Hi both. Glad I could help.

In the future do not hesitate to run the parsing over your files for validation :-).

@GiacomoXT
Copy link

Hi both. Glad I could help.

In the future do not hesitate to run the parsing over your files for validation :-).

Sure, it's a good idea.

(Thanks to @sognetic , since a bit of time we have a unit test in place that runs EvtGen with all the new signal decfiles added to basf2 via merge request, so luckily we are not adding anymore broken decfiles! But using DecayLanguage would be definitely faster.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants