Skip to content

Commit

Permalink
chore: skip /opt/python/cp38-cp38/bin/python in cibuildwheel
Browse files Browse the repository at this point in the history
  • Loading branch information
@jpivarski
jpivarski committed Nov 8, 2024
1 parent 59ac11e commit 8bbc8a6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cibuildwheel.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ pytest {project}/tests \
{package}/tests-spec-explicit
"""
skip = [
"*p38*",
"pp*win*",
"pp*-manylinux_i686",
]
Expand Down

8 comments on commit 8bbc8a6

@jpivarski
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryiii, is this appropriate? I'm trying to prevent cibuildwheel from using /opt/python/cp38-cp38/bin/python in https://github.com/scikit-hep/awkward/actions/runs/11732889261/job/32686059695

The error is

Testing wheel...
  
      + mktemp -d
      + uv venv /tmp/tmp.CbNPfr4dgu/venv --python /opt/python/cp38-cp38/bin/python
  Using CPython 3.8.20 interpreter at: /opt/python/cp38-cp38/bin/python
  Creating virtual environment at: /tmp/tmp.CbNPfr4dgu/venv
      + uv pip install /tmp/cibuildwheel/repaired_wheel/awkward_cpp-41-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
  Resolved 4 packages in 101ms
  Prepared 2 packages in 312ms
  Installed 4 packages in 25ms
   + awkward-cpp==41 (from file:///tmp/cibuildwheel/repaired_wheel/awkward_cpp-41-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl)
   + importlib-resources==6.4.5
   + numpy==1.24.4
   + zipp==3.20.2
      + uv pip install 'pytest>=6' .
    × No solution found when resolving dependencies:
    ╰─▶ Because the current Python version (3.8.20) does not satisfy Python>=3.9
        and awkward==2.7.0 depends on Python>=3.9, we can conclude that
        awkward==2.7.0 cannot be used.
        And because only awkward==2.7.0 is available and you require awkward, we
        can conclude that your requirements are unsatisfiable.
                                                              ✕ 1.22s
Error: Command ['uv', 'pip', 'install', 'pytest>=6', '.'] failed with code 1. 

Error: Process completed with exit code 1.

@henryiii
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it this way, but it’s much better to change requires-Python, and cibuildwheel will respect that.

@henryiii
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you just want to skip the test, there’s a test-skip.

@henryiii
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed:

awkward/awkward-cpp/pyproject.toml

Line 49 in 8bbc8a6

requires-python = ">=3.8"

@jpivarski
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's exactly what I missed and now I'm trying to set it right in e0f5feb. I've bumped all of the version numbers (awkward-cpp and awkward) because the only full test of this is to try building a new awkward-cpp.

@jpivarski
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked! https://github.com/scikit-hep/awkward/actions/runs/11746408549

I didn't deploy a new awkward-cpp (https://pypi.org/project/awkward-cpp/#history), but I did a dry-run of the machinery. The awkward-cpp that is in PyPI is not very wrong: it says that it works for Python 3.8, but there isn't an awkward package that accepts this awkward-cpp version and also works for Python 3.8, so it's effectively excluded.

I saw earlier that @matthewfeickert noticed that, too. Sorry for the confusion! I thought I was deploying this correctly, but I wasn't.

Other than that, the awkward-cpp in PyPI is okay, and I'll replace it the next time we actually make a change to the C++ code, which is likely soon.

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented on 8bbc8a6 Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw earlier that @matthewfeickert noticed that, too. Sorry for the confusion! I thought I was deploying this correctly, but I wasn't.

Yeah, this will be fixed in PR #3297. No worries too. It happens. :)

The awkward-cpp that is in PyPI is not very wrong: it says that it works for Python 3.8, but there isn't an awkward package that accepts this awkward-cpp version and also works for Python 3.8, so it's effectively excluded.

Yeah, I think it is all fine. I've also gone ahead and fixed everything on conda-forge, so the deployments everywhere should be current and stable now.

@jpivarski
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

Please sign in to comment.