Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SDist CMake option #454

Merged
merged 1 commit into from
Aug 10, 2023
Merged

feat: SDist CMake option #454

merged 1 commit into from
Aug 10, 2023

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Aug 9, 2023

Working on #392.

  • Add to setuptools build_meta, too

For later PR:

+    libpl = sysconfig.get_config_var("LIBPL")
+    library = sysconfig.get_config_var("LIBRARY")
+
+    if libpl and library and Path(libpl).joinpath(library).is_file():
+        assert isinstance(libpl, str)
+        assert isinstance(library, str)
+        return Path(libpl) / library

@henryiii henryiii force-pushed the henryiii/feat/sdist branch 5 times, most recently from c63897b to 9c9f331 Compare August 9, 2023 20:02
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii marked this pull request as ready for review August 9, 2023 23:35
@henryiii henryiii merged commit 196c8ce into main Aug 10, 2023
34 of 36 checks passed
@henryiii henryiii deleted the henryiii/feat/sdist branch August 10, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant