Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Adds option for single account id config #12

Closed
wants to merge 0 commits into from

Conversation

mikef-nl
Copy link
Contributor

@mikef-nl mikef-nl commented Dec 6, 2024

#11

@mikef-nl mikef-nl changed the title Adds option for single account id config feature: Adds option for single account id config Dec 6, 2024
@mikef-nl mikef-nl added the feature New feature or request label Dec 6, 2024
Copy link
Member

@shoekstra shoekstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

If you can please fix variable formatting then this is good to go 🚀

variables.tf Outdated
Comment on lines 46 to 50
validation {
condition = var.config.zone_name != "" || var.config.single_account_id != ""
error_message = "Either zone_name or single_account_id is required"
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
validation {
condition = var.config.zone_name != "" || var.config.single_account_id != ""
error_message = "Either zone_name or single_account_id is required"
}
validation {
condition = var.config.zone_name != "" || var.config.single_account_id != ""
error_message = "Either zone_name or single_account_id is required"
}

Please fix the formatting here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants