feat Added support for SecurityHub integration findings #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks clean and following the design patterns properly. 👍 |
|
@fernandogoncalves-me please resolve the linting issue. If you have any issues with the pipeline ping me. The tooling and setup is obsolete. |
marwinbaumannsbp
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes adding support for suppressing findings coming from Security Hub integrations with other AWS services.
Findings detected by other services (e.g. Amazon Inspector) miss the key attribute currently used to query findings that should be suppressed:
ControlId.A JSON example of an Inspector finding can be found in the fixtures folder.
To overcome that limitation, this PR proposes adding support for 2 new suppression fields:
product_name: this field contains the name of the product that has created the finding (e.g.Inspector).title: this field contains the title of the finding.By combining these 2 extra fields, we would be able to suppress findings coming from any other service that integrates with Security Hub.
And by leveraging the resource ID regex feature, we have full control to make make those suppressions more or less permissive.