Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cofactor_det: type stability improvements #20

Closed
wants to merge 1 commit into from
Closed

cofactor_det: type stability improvements #20

wants to merge 1 commit into from

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Nov 24, 2023

No description provided.

@scheinerman
Copy link
Owner

Please explain the rationale here. I don't understand how this is an improvement.

@nsajko
Copy link
Contributor Author

nsajko commented Nov 27, 2023

I've recently made lots of PRs to MultivariatePolynomials.jl, DynamicPolynomials.jl and MutableArithmetics.jl with the goal of improving the MultivariatePolynomials.jl implementation of LinearAlgebra.det. The implementation in JuliaAlgebra/MultivariatePolynomials.jl#282 is generic, so I guess I'll try to contribute it here, too, after that PR is merged. In any case, this PR is superseded.

@nsajko nsajko closed this Nov 27, 2023
@nsajko nsajko deleted the cofactor_det_type_stability branch November 27, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants