Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove UpdateBucketCapacityJobTakingTooLong alert #303

Merged

Conversation

Kerkesni
Copy link
Contributor

UpdateBucketCapacityJobTakingTooLong creates noise and is not useful as what we truly want to monitor is having multiple jobs failing in series.

NoSuccessfulUpdateBucketCapacityJobRunIn10m already tests that as jobs are only run one at a time and at a 4 minute interval.

Issue: S3UTILS-150

@bert-e
Copy link
Contributor

bert-e commented Nov 14, 2023

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@scality scality deleted a comment from bert-e Nov 14, 2023
@bert-e
Copy link
Contributor

bert-e commented Nov 14, 2023

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@Kerkesni Kerkesni marked this pull request as ready for review November 15, 2023 08:57
@Kerkesni Kerkesni changed the base branch from development/1.13 to development/1.14 November 15, 2023 10:07
@Kerkesni Kerkesni force-pushed the bugfix/S3UTILS-150-fix-bucket-capacity-alerts branch from 28def11 to b6bcac8 Compare November 15, 2023 10:08
@scality scality deleted a comment from bert-e Nov 15, 2023
@bert-e
Copy link
Contributor

bert-e commented Nov 15, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni Kerkesni force-pushed the bugfix/S3UTILS-150-fix-bucket-capacity-alerts branch from deb5624 to 1edabcc Compare November 17, 2023 15:55
@Kerkesni Kerkesni changed the base branch from development/1.14 to development/1.13 November 28, 2023 10:58
UpdateBucketCapacityJobTakingTooLong creates noise and is not useful
as what we truly want to monitor is having multiple jobs failing in
series.

NoSuccessfulUpdateBucketCapacityJobRunIn10m already tests that as jobs
are only run one at a time and at a 4 minute interval.

Issue: S3UTILS-150
@Kerkesni Kerkesni force-pushed the bugfix/S3UTILS-150-fix-bucket-capacity-alerts branch from 1edabcc to 7d2df0b Compare November 28, 2023 11:02
@scality scality deleted a comment from bert-e Nov 28, 2023
@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2023

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@Kerkesni
Copy link
Contributor Author

/create_integration_branches

@scality scality deleted a comment from bert-e Nov 28, 2023
@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@Kerkesni
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.13

  • ✔️ development/1.14

The following branches will NOT be impacted:

  • development/1.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.13

  • ✔️ development/1.14

The following branches have NOT changed:

  • development/1.4

Please check the status of the associated issue S3UTILS-150.

Goodbye kerkesni.

@bert-e bert-e merged commit 7d2df0b into development/1.13 Nov 28, 2023
12 checks passed
@bert-e bert-e deleted the bugfix/S3UTILS-150-fix-bucket-capacity-alerts branch November 28, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants