Improvement: osis 147 stop osis failure on decryption #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the capability of handling decryption faulire for secret key data stored in redis sentinel by the method `retrieveSecretKey` used by get and get credentials APIs. - Does not throw any error for any decryption failure - Logs all decryption failures - Removes the keys from Redis automatically for any decryption failure, the keys remain in vault and can be used the user if secret key is accessible
anurag4DSB
requested review from
KillianG,
BourgoisMickael and
fredmnl
and removed request for
a team
BourgoisMickael
approved these changes
May 21, 2024
fredmnl
approved these changes
May 22, 2024
|
/approve |
anurag4DSB
deleted the
improvement/OSIS-147-stop-osis-failure-on-decryption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: VMware needs secret keys to be available on-demand which is contrary to AWS standard where secret keys are only shown at creation time. To achieve this OSIS stores any created access keys via OSIS in redis in AWS GCM in encrypted format.
Issue: Due to S3C-7645 not being done, an issue occurs when doing a rolling deployment with new nodes on a cluster where OSIS is already enabled. This issue makes VMware cloud director UI un-usable by the end users.
The resolution/changes per discussion with product/customer/CS and Accounts team
This adds the capability of handling decryption failures for secret key data stored in Redis Sentinel using the method
retrieveSecretKeyused by the get and get credentials APIs.the keys remain in vault and can be used the user if secret key is
accessible
Note to reviewers: We are fixing this in RING 9, for RING 8 we have a TSKB for internal CS and for customers as well: https://github.com/scality/tskb/pull/457