COSI-53: Optimize CI Workflows, Mono-Repo Migration, and Enhancements #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurag4DSB
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 93.40% 93.40%
=======================================
Files 9 9
Lines 637 637
=======================================
Hits 595 595
Misses 36 36
Partials 6 6 |
anurag4DSB
force-pushed
the
improvement/COSI-53-misc-ci-improvements
branch
from
1e7c78a to
0bbfed6
Compare
This commit parallelizes two steps in the CI workflow, adds if: always where needed, and includes minor lint changes.
anurag4DSB
force-pushed
the
improvement/COSI-53-misc-ci-improvements
branch
from
0bbfed6 to
4242967
Compare
renamed in .github/workflows: - ci-build-and-unit-tests.yml -> build-and-unit-tests.yml - ci-e2e-tests.yml -> e2e-feature-tests.yml - ci-smoke-tests.yml -> helm-validation.yml
- The old repos have been archived and everything has been moved to a mono-repo - Updated CI workflows and scripts to reflect the same
anurag4DSB
force-pushed
the
improvement/COSI-53-misc-ci-improvements
branch
from
1adf835 to
31d4874
Compare
anurag4DSB
force-pushed
the
improvement/COSI-53-misc-ci-improvements
branch
from
31d4874 to
9c4e7f0
Compare
anurag4DSB
changed the title
dvasilas
approved these changes
Jan 3, 2025
| echo "=== Loading cached S3 and IAM Docker images ===" | ||
| if [ -d /tmp/.docker_cache ] && [ "$(ls -A /tmp/.docker_cache 2>/dev/null)" ]; then | ||
| for image in /tmp/.docker_cache/*.tar; do | ||
| docker load -i "$image" || true # continue on failure |
There was a problem hiding this comment.
isn't there an action that can load from the cache or save images to cache ?
There was a problem hiding this comment.
Yes, there is, but I can't use them in a script when doing things in parallel.
Ideally, we would want to use the action, but GitHub doesn't allow parallel actions on the same machine yet.
What do you think?
BourgoisMickael
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces multiple improvements to CI workflows and project organization:
Commit 1. Parallelized CI Steps: Optimized workflow execution by parallelizing steps and adding if: always where necessary.
Commit 2. Renamed Workflows files and updated CI workflow names for clarity:
Commit 3. CNCF Mono-Repo Migration: use mono-repo as others have been archived; updated workflows and scripts.
Commit 4. Improved Coverage: Set GOCOVERDIR to reduce Codecov failures.
Commit 5. Enhanced Logging: Updated commands to improve output visibility in GitHub UI and logs.