COSI 74, COSI 75: Brownfield use case (re-use existing S3 buckets in Kube)

[anurag4DSB]

Brownfield use case.

Commit # 1: remove silent success if the user already owns the bucket - this is a brownfield case
Commit # 2: Add CRs (custom resources yaml files) for the brownfield use case.
Commit # 3: Added e2e tests for brownfield use case
Commit # 4: Reorganized greenfield CRs in a greenfield folder

Note to reviewers: It is intentional that brownfield CRs are in the same namespace as cosi driver as the sidecar in the cosi driver pod(controlled by CNCF) needs to patch events and that cannot be done cross namespace Reference

Code reference from k8s

if e.GetNamespace() != "" && event.Namespace != e.GetNamespace() {
		return nil, fmt.Errorf("can't patch an event with namespace '%v' in namespace '%v'", event.Namespace, e.GetNamespace())
	}

Documentation coming soon
Context for branch name: It started with a bug fix, but we ended up understanding how brownfield case works.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.40%. Comparing base (52e13ca) to head (a3e7337).
Report is 5 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
pkg/driver/provisioner_server_impl.go	97.64% <ø> (-0.06%)	⬇️

Components	Coverage Δ
🏠 Main Package	∅ <ø> (∅)
🚗 Driver Package	92.22% <ø> (-0.17%)	⬇️
📡 gRPC Factory Package	81.65% <ø> (ø)
🔐 IAM Client Package	100.00% <ø> (ø)
🌐 S3 Client Package	100.00% <ø> (ø)
🔧 Util Package	100.00% <ø> (ø)
🔖 Constants Package	∅ <ø> (∅)

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   93.46%   93.40%   -0.07%     
==========================================
  Files           9        9              
  Lines         643      637       -6     
==========================================
- Hits          601      595       -6     
  Misses         36       36              
  Partials        6        6              

[anurag4DSB]

In this line the name and directory was changed.
This check-in went unchecked in an older PR with the old name of the yaml file

[fredmnl]

Ok, I'll recap to verify that I'm understanding everything correctly:

• brownfield means that you were already using a bucket for an application before the introduction of cosi. Therefore, you will need to import this existing bucket into cosi.
• you removed the BucketIsAlreadyOwnedByYou case since now there is an actual path for brownfield. In other words, we now know that BucketIsAlreadyOwnedByYou is not the legit path for the brownfield use case.

[fredmnl]

Perhaps we could perform some action on the bucket since we have everything we need at this stage, even just a HeadBucket or ListObjects, if that's not too complicated.

[anurag4DSB]

I added a test in the lastest review commit

[anurag4DSB]

Ok, I'll recap to verify that I'm understanding everything correctly:

• brownfield means that you were already using a bucket for an application before the introduction of cosi. Therefore, you will need to import this existing bucket into cosi.
• you removed the BucketIsAlreadyOwnedByYou case since now there is an actual path for brownfield. In other words, we now know that BucketIsAlreadyOwnedByYou is not the legit path for the brownfield use case.

100% accurate.