-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lifecycle transitions on OOB bucket #2606
base: development/9.0
Are you sure you want to change the base?
Conversation
Issue: BB-590
Make OOB location-aware, and thus do not delete the Zenko object when it gets removed from S3C by gc at the end of the transition. Issue: BB-590
This custom (but reserved) user metadata field is set by Cloudserver when restoring cold object in OOB bucket. Issue: BB-590
Issue: BB-590
Instead of rebuilding the whole metadata on updates, simply update the required fields, i.e. tags. This also fixes subtle issues, where some fields from Zenko may be overwritten when some operations are performed on s3c. Issue: BB-590
If the bucket has no lifecycle or notification configuration, we don't need the oplog update, and can skip it to lower the load on mongo. Issue: BB-590
An oplog update is only required when the object is archived, instead of when lifecycle is enabled: so fix the condition to avoid extra associated load. The update is also required when bucket notification is enabled on the bucket, no change there. Issue: BB-590
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 5 files with indirect coverage changes
@@ Coverage Diff @@
## development/9.0 #2606 +/- ##
===================================================
+ Coverage 54.35% 54.69% +0.34%
===================================================
Files 201 201
Lines 13336 13368 +32
===================================================
+ Hits 7249 7312 +63
+ Misses 6077 6046 -31
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
Core idea is to consider that OOB does not sync the whole bucket, but only the objects which are indeed in the OOB location : there may be objects in Zenko which are not in Metadata, as long as they are not marked as present in that location.
This requires just a few changes:
x-amz-meta-scal-version-id
): this is used to ensure we do not duplicate the object when it is restored.Issue: BB-590