Skip to content

Commit

Permalink
lifecycle-conductor: check transition processor lag
Browse files Browse the repository at this point in the history
There may be lag on the transition processor, should throttle the
conductor as well.

Issue: BB-437
  • Loading branch information
francoisferrand committed Oct 3, 2023
1 parent c5b4e58 commit 1596051
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
10 changes: 8 additions & 2 deletions extensions/lifecycle/conductor/LifecycleConductor.js
Original file line number Diff line number Diff line change
Expand Up @@ -747,12 +747,18 @@ class LifecycleConductor {
this.lcConfig.bucketTasksTopic,
this.lcConfig.bucketProcessor.groupId, 0, next),

// check that object tasks topic consumer lag is 0
objectTasksCheck:
// check that object tasks topic consumer lag for expirations is 0
objectTasksExpirationCheck:
next => this._kafkaBacklogMetrics.checkConsumerLag(
this.lcConfig.objectTasksTopic,
this.lcConfig.objectProcessor.groupId, 0, next),

// check that object tasks topic consumer lag for transitions is 0
objectTasksTransitionCheck:
next => this._kafkaBacklogMetrics.checkConsumerLag(
this.lcConfig.objectTasksTopic,
this.lcConfig.transitionProcessor.groupId, 0, next),

// check that data mover topic consumer has progressed
// beyond the latest lifecycle snapshot of topic offsets,
// which means everything from the latest lifecycle batch
Expand Down
6 changes: 6 additions & 0 deletions tests/functional/lifecycle/LifecycleConductor.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,9 @@ describe('lifecycle conductor', function lifecycleConductor() {
objectProcessor: {
groupId: 'b',
},
transitionProcessor: {
groupId: 'c',
},
};

// make topic unique so that different tests' bootstrap messages don't interfere
Expand Down Expand Up @@ -279,6 +282,9 @@ describe('lifecycle conductor', function lifecycleConductor() {
objectProcessor: {
groupId: 'b',
},
transitionProcessor: {
groupId: 'c',
},
};

// make topic unique so that different tests' bootstrap messages don't interfere
Expand Down

0 comments on commit 1596051

Please sign in to comment.