Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #135: Identify package names in extension clause #136

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki linked an issue Aug 21, 2020 that may be closed by this pull request
Copy link
Contributor

@MaximeKjaer MaximeKjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things stand out to me here:

  1. The dots aren't highlighted. I think we should aim to highlight the dots in the qualified name as punctuation, like we do for qualified names in imports.
  2. The package names are highlighted as scala.source, whereas they are highlighted as entity.name.import.scala for imports. With my editor theme, package names show up as yellow in imports, and white in extends. Should we aim to unify the two? For instance, the package names in extends could be entity.name.scala.

Different highlightings for package names in import and extends

@nicolasstucki
Copy link
Contributor Author

The unification idea sounds good but I would do it on it as a separate enhancement. The current fix targets a simple but common issue that I which to fix before GitHub updates the syntax adding this bug.

I will open a separate issue for the unification idea.

@MaximeKjaer
Copy link
Contributor

Perfect, I see you've opened #143. Since we're tracking that issue, we can merge this now.

@MaximeKjaer MaximeKjaer merged commit 40dc063 into scala:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extends should not highlight packages as types
2 participants