Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.12.8 + ThisBuild slash syntax #30

Merged
merged 3 commits into from
Jan 17, 2019
Merged

Conversation

eed3si9n
Copy link
Member

No description provided.

@SethTisue
Copy link
Member

SethTisue commented Jan 9, 2019

  • context: I'm a Simpler seed #2 sympathizer, which means that I wish there was no multi-project stuff at all in this
  • that aside, though, avoiding inThisBuild in favor of standard slash syntax stuff seems wise to me, fewer things for newcomers to absorb
  • I'm less sure about the wisdom of including the Sonatype stuff, even commented-out. 95%, perhaps 98% or 99%, of the audience for this template will never publish anything to Sonatype in their entire lives

@eed3si9n
Copy link
Member Author

eed3si9n commented Jan 9, 2019

#2 says "This seed seems to complicated for a minimum sbt project," which I agree, because if people wanted minimum sbt project, you don't need a seed; all you need is touch build.sbt, which I demonstrate in create a minimum sbt build.

The fundamental premise of "sbt new" I think is that copy-pasting build file is ok to quickly move on to more important things.

95%, perhaps 98% or 99%, of the audience for this template will never publish anything to Sonatype in their entire lives

I am not too sure about that. If someone is using this template, they are starting a new build from scratch as opposed to git cloning someone else's build, like in the case of Coursera or Creative Scala. There are 75 forks to this repo. Maybe people who would fork things would have higher correlation, but 5% means fewer than four people on https://github.com/scala/scala-seed.g8/network/members will ever publish things to Sonatype in their lifetime.

@SethTisue
Copy link
Member

95%, perhaps 98% or 99%, of the audience for this template will never publish anything to Sonatype in their entire lives

I stand by this claim. Open source maintainers are a tiny, tiny fraction of the overall community, and this template is intended for beginners, making the fraction even tinier.

I'd be happy to merge this without the Sonatype stuff. (I'd also stand aside if there was a consensus opinion that the Sonatype stuff should be there.)

@SethTisue
Copy link
Member

possible compromise: how about including a one-line comment with a link to some other resource providing Sonatype publishing information?

@eed3si9n
Copy link
Member Author

eed3si9n commented Jan 17, 2019 via email

@SethTisue SethTisue merged commit 59b2ed6 into scala:2.12.x Jan 17, 2019
@eed3si9n eed3si9n deleted the wip/bumpsbt branch June 10, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants