-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove clone command + Highlight npx command #41
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pushed a small tweak in 1137a0a to set the same border color to the extensions install command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol that Blue color on the border pops out too much for me, I like the previous subtle gray border.
But we could always tinker later, looks good to me! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Oh, I think it's good to highlight the main CTA of the page, it doesn't look too much for me at all (now that we only have 1 command). But happy to reconsider later on. |
As we discussed yesterday, we are moving away from SE-2 clone method. The first step is to remove it from the docs / READMEs / etc.
I removed it here + highlighted the npx command a bit.
before
after
--
What do you all think? Happy to tweak
We can also wait to merge if we want to sync with other PRs.
Related scaffold-eth/scaffold-eth-2#993