Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clone command + Highlight npx command #41

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Remove clone command + Highlight npx command #41

merged 2 commits into from
Nov 21, 2024

Conversation

carletex
Copy link
Member

@carletex carletex commented Nov 21, 2024

As we discussed yesterday, we are moving away from SE-2 clone method. The first step is to remove it from the docs / READMEs / etc.

I removed it here + highlighted the npx command a bit.

before
image

after
image

--

What do you all think? Happy to tweak

We can also wait to merge if we want to sync with other PRs.

Related scaffold-eth/scaffold-eth-2#993

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scaffoldeth-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 10:20am

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pushed a small tweak in 1137a0a to set the same border color to the extensions install command

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol that Blue color on the border pops out too much for me, I like the previous subtle gray border.

But we could always tinker later, looks good to me! Thanks!

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@carletex
Copy link
Member Author

Lol that Blue color on the border pops out too much for me, I like the previous subtle gray border.

Oh, I think it's good to highlight the main CTA of the page, it doesn't look too much for me at all (now that we only have 1 command). But happy to reconsider later on.

@carletex carletex merged commit 4afb041 into main Nov 21, 2024
3 checks passed
@carletex carletex deleted the remove-clone branch November 21, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants