-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shell script for prod deployments + modify Makefile accordingly #972
base: foundry
Are you sure you want to change the base?
Conversation
Hey port thanks for this!! Can you please resolve the merge conflicts we did some tweaks in #1011 🙌 |
Hey ofc! Will work on this today! |
Will do some more testing + UX improvements and ask for your review! |
Alright now we get: 1223.4.mp4Also the |
Hello!
This PR:
-> adds a shell script to give the user a menu for selecting a keystore when deploying to any network other than the local anvil node
-> modifies the makefile to pass in the RPC_URL from the foundry.toml file to the shell script
-> works in linux and macos, since foundry does not work on windows natively, windows is ignored. So we should test this on: linux + wsl + macos
-> removes the need to modify the .env file when changing keystores to use
Possible To-Do:
-> ‘—keystore’ flag (thx to Shiv for the suggestion) I have some working code on this, but it accepts variables like this:
yarn deploy --network sepolia my-keystore
instead of
yarn deploy --network sepolia --keystore my-keystore
We can also introduce a new script as I couldn't find how to achieve this without doing so. Tried passing in another flag in the package.json, but did not work.