Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell script for prod deployments + modify Makefile accordingly #972

Open
wants to merge 9 commits into
base: foundry
Choose a base branch
from

Conversation

portdeveloper
Copy link
Contributor

@portdeveloper portdeveloper commented Oct 24, 2024

Hello!

This PR:

-> adds a shell script to give the user a menu for selecting a keystore when deploying to any network other than the local anvil node
-> modifies the makefile to pass in the RPC_URL from the foundry.toml file to the shell script
-> works in linux and macos, since foundry does not work on windows natively, windows is ignored. So we should test this on: linux + wsl + macos
-> removes the need to modify the .env file when changing keystores to use

Possible To-Do:

-> ‘—keystore’ flag (thx to Shiv for the suggestion) I have some working code on this, but it accepts variables like this:
yarn deploy --network sepolia my-keystore
instead of
yarn deploy --network sepolia --keystore my-keystore
We can also introduce a new script as I couldn't find how to achieve this without doing so. Tried passing in another flag in the package.json, but did not work.

@portdeveloper portdeveloper marked this pull request as ready for review October 31, 2024 05:23
@technophile-04
Copy link
Collaborator

Hey port thanks for this!! Can you please resolve the merge conflicts we did some tweaks in #1011 🙌

@portdeveloper
Copy link
Contributor Author

Hey ofc! Will work on this today!

@portdeveloper
Copy link
Contributor Author

Will do some more testing + UX improvements and ask for your review!

@portdeveloper portdeveloper marked this pull request as draft December 18, 2024 07:40
@portdeveloper
Copy link
Contributor Author

portdeveloper commented Dec 23, 2024

Alright now we get:
-> a direct deployment to the local chain when we run yarn deploy
-> a menu in the console when we do a yarn deploy --network sepolia
image
-> a direct deployment to the specified chain with the specified keystore when we do a yarn deploy --network sepolia --keystore zort (I remember @technophile-04 suggesting this somewhere)
image

1223.4.mp4

Also the deploy-verify target in the Makefile is unreachable I think 🤔

@portdeveloper portdeveloper marked this pull request as ready for review December 23, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants