Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show inherited functions in Debug (when deploying with foundry) #604

Merged

Conversation

FilipHarald
Copy link
Contributor

Description

This implements the same inheritedFrom functionality previously done for hardhat. Also, I did a small renaming in hardhat-scripts.

First try was here: #602
⚠️ contains changes from #603

Additional Information

Related Issues

Related to discussion #558 and PR #564

Your ENS/address: harmont.eth

@technophile-04
Copy link
Collaborator

Also, I did a small renaming in hardhat-scripts

What did you update? I think it would be really great if we update it in main first so that we don't diverge cli from main

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FilipHarald 🙌 I think this looks great also tested it with #564 (comment) and seems to work correctly !!

@technophile-04 technophile-04 merged commit 621c9ac into scaffold-eth:cli Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants