-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update wagmi, viem, rainbowkit #580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technophile-04
requested review from
carletex,
damianmarti,
rin-st and
Pabl0cks
October 20, 2023 16:11
rin-st
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Pabl0cks
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been playing with it in local and with deployed version, and is looking nice! 🙌
GJ Shiv!!
Tysm for reviews all, merging this 🙌 |
carletex
added a commit
that referenced
this pull request
Oct 23, 2023
* Tweak DaisyUI `link` (#560) * Improve ENS support (accept all TLDs) (#563) * fix: memo history events (#565) Co-authored-by: Carlos Sánchez <[email protected]> * Extract header menu links (#570) * Move Block Explorer to footer (#574) * Remove ExampleUI (pages, components, assets, content) (#578) * update wagmi, viem, rainbowkit (#580) * add zkSync, scroll & polygonZkEvm to foundry.toml * add changeset --------- Co-authored-by: Filip Harald <[email protected]> Co-authored-by: Greg <[email protected]> Co-authored-by: Rinat <[email protected]> Co-authored-by: Carlos Sánchez <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Its been a long since we didn't updated them. Also nicely tested it, there are no breaking changes...we also did the same in #535 (comment)
here is test prod app deployed with `yarn vercel: https://wagmi-viem-up.vercel.app
Also now
viem/chains
is single source of truth both for wagmi internally and for SE-2 too 🙌This also fixes #579 since in the recent
veim
version scroll mainnet was added, also added it in hardhat.Additional Information
Related Issues
Closes #579
Your ENS/address: shivbhonde.eth