fix: move warnings to useEffect (#1016)

scaffold-eth · Dec 18, 2024 · 24fe055 · 24fe055
1 parent 476010a
commit 24fe055
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 12 deletions.
diff --git a/packages/nextjs/hooks/scaffold-eth/useDeployedContractInfo.ts b/packages/nextjs/hooks/scaffold-eth/useDeployedContractInfo.ts
@@ -37,12 +37,13 @@ export function useDeployedContractInfo<TContractName extends ContractName>(
   const finalConfig: UseDeployedContractConfig<TContractName> =
     typeof configOrName === "string" ? { contractName: configOrName } : (configOrName as any);
 
-  if (typeof configOrName === "string") {
-    console.warn(
-      "Using `useDeployedContractInfo` with a string parameter is deprecated. Please use the object parameter version instead.",
-    );
-  }
-
+  useEffect(() => {
+    if (typeof configOrName === "string") {
+      console.warn(
+        "Using `useDeployedContractInfo` with a string parameter is deprecated. Please use the object parameter version instead.",
+      );
+    }
+  }, [configOrName]);
   const { contractName, chainId } = finalConfig;
   const selectedNetwork = useSelectedNetwork(chainId);
   const deployedContract = contracts?.[selectedNetwork.id]?.[contractName as ContractName] as Contract<TContractName>;

diff --git a/packages/nextjs/hooks/scaffold-eth/useScaffoldWriteContract.ts b/packages/nextjs/hooks/scaffold-eth/useScaffoldWriteContract.ts
@@ -1,4 +1,4 @@
-import { useState } from "react";
+import { useEffect, useState } from "react";
 import { MutateOptions } from "@tanstack/react-query";
 import { Abi, ExtractAbiFunctionNames } from "abitype";
 import { Config, UseWriteContractParameters, useAccount, useWriteContract } from "wagmi";
@@ -60,11 +60,13 @@ export function useScaffoldWriteContract<TContractName extends ContractName>(
       : (configOrName as UseScaffoldWriteConfig<TContractName>);
   const { contractName, chainId, writeContractParams: finalWriteContractParams } = finalConfig;
 
-  if (typeof configOrName === "string") {
-    console.warn(
-      "Using `useScaffoldWriteContract` with a string parameter is deprecated. Please use the object parameter version instead.",
-    );
-  }
+  useEffect(() => {
+    if (typeof configOrName === "string") {
+      console.warn(
+        "Using `useScaffoldWriteContract` with a string parameter is deprecated. Please use the object parameter version instead.",
+      );
+    }
+  }, [configOrName]);
 
   const { chain: accountChain } = useAccount();
   const writeTx = useTransactor();