templatise foundry.toml and remove --via-ir flag #189
Merged
+78
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technophile-04
force-pushed
the
foundry-changes
branch
from
2947be3 to
713befe
Compare
rin-st
reviewed
Jan 3, 2025
templates/solidity-frameworks/foundry/packages/foundry/foundry.toml.template.mjs
Outdated
Show resolved
Hide resolved
templates/solidity-frameworks/foundry/packages/foundry/foundry.toml.template.mjs
Outdated
Show resolved
Hide resolved
|
Thanks for updates! What about this?
|
Ohh my bad, updated it 🙌 |
|
Thanks @rin-st! Merging this 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Templatised the
foundry.tomlfile. Lol I wanted to templatise it from beginning but didn't had good use case in our core extensions.In scaffold-eth#1023 we will be removing default
--via-irflag and allowing people to pass it if required tofoundry.tomlfile.--via-irflag is required for ctf-extension checkout https://github.com/carletex/ctf-devcon/pull/154.To test:
Switch to this branch.
yarn buildGet the args from example extension pr