Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge package.json files #181

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Fix merge package.json files #181

merged 3 commits into from
Dec 25, 2024

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Dec 24, 2024

If you have package.json files in both hardhat and foundry folders of your extension, installation breaks. PR fixes it.

Extension to test (just two empty package.json files in both folders). Try from main and from this PR branch.

yarn cli -e rin-st/test-merge-packages

extension repo: https://github.com/rin-st/test-merge-packages

Note: I changed regex from ${sf}$ to ${sf}. Wondering how first even worked since it requires solidityFramework at the end of the path.

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rin-st, makes sense!

Note: I changed regex from ${sf}$ to ${sf}. Wondering how first even worked since it requires solidityFramework at the end of the path.

I think we added that assuming the folder structure of local extensions(solidity framework) since their path follows ~extensionName ~solidity-framework/hardhat/packages/hardhat, we added that in https://github.com/scaffold-eth/create-eth/pull/90/files.

But yeah I the current logic makes more sense 🙌

@technophile-04 technophile-04 merged commit aed3345 into main Dec 25, 2024
1 check passed
@technophile-04 technophile-04 deleted the fix-merge-packages branch December 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants