Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format package.json files #165

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

moltam89
Copy link

@moltam89 moltam89 commented Dec 5, 2024

Hey guys,

This is a small enhancement to help the development workflow.

When testing an extension locally with yarn cli -e {projectName} --dev --skip, all the package.json files are squashed into 1 line.
With this fix, the package.json files will look normal.

I created a testJSON repo where there are actual changes in the main package.json file, but this issue should be reproducible with any extension.

Note:
This is not a problem when we use an extension from GitHub, because the original file's formatting is preserved. So in the case of yarn cli -e moltam89/testJSON --skip, the package.json files will look okay.

Cheers,
Tamas

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moltam89 ! Works great!

Copy link
Member

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moltam89

I remember facing this and it was annoying haha

@carletex carletex merged commit ef55492 into scaffold-eth:main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants