Content Rating API #328
Open
Content Rating API #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please note, these changes are not backwards compatible. The exported view properties now match the properties of the DFPBannerView. I've now implemented the `validAdSizes` property, and replaced the `testDeviceID` property with `testDevices`. Also the simulator device id can be specified using `PublisherBanner.simulatorId` instead of `"EMULATOR"`. The conversion of json to GADAdSize is now implemented using a RCTConvert category. And lastly, the `loadBanner` method is now exposed to react, to allow easy banner refresh, and removes the need of checking which properties are available before making a request to admob.
this omits the need of explicit conversion
also, there are no nativeOnly events so removed those
instead of the mixed names like RNAdMobManager and BannerView they're all named like the implemented class, e.g. RNGADBannerView and RNGADBannerViewManager.
replaced deprecated RCTEventDispatcher with RCTEventEmitter
replaced deprecated RCTEventDispatcher with RCTEventEmitter
this is more or less the bare minimum, we should probably add some rules along the way
Override abstract method onRewardedVideoCompleted()
Performance & React Native 0.51
Fix "Argument list too long: recursive header expansion failed" issue
Updates gradle to use React-Native and Android's latest standards for improving dependency management.
RNAdMobBanner RNAdMobBanner
* fix Illegal callback invocation from native module. crash * remove newline
…ded() is called before requestAd() (#241) * Fix: make sure we only invoke requestPromise once * Fix: check if mRewardedVideoAd is not null before calling .isLoaded() * remove newline
when using React Native AdMob with cocoapods, you have to add `Google-Mobile-Ads-SDK` to your `Podfile` manually, because that framework contains a binary framework, which isn't supported when used with `use_frameworks!`.
this updates the example app to use cocoapods to integrate all libraries
update example app using latest "react-native init" (0.60.5)
The UITests have been updated to assert ads are rendered. Something similar has to be done for Android implementation.
add GitHub workflow that sets up a React Native project with the library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have an application targeted for G [3+] populations (cf. https://support.google.com/admob/answer/7562142?hl=en&ref_topic=7384665) that use admob SDK for providing some ads (Banner and Interstitial).
After submitting the app to google play, it was rejected because it should include instructions like this :
AdRequest request = new AdRequest.Builder().tagForChildDirectedTreatment(true).build();
adView.loadAd(request);
But, this SDK don’t provide any way (as specifying the emulator devices) to set such configurations,
Could you please add this new requirements to your SDK?
Regards.