-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest sbt-site in scripted test #56
Conversation
See
This is because sbt-site, starting with v1.5, is now spilt into separate modules per site generator. See https://www.scala-sbt.org/sbt-site/migration-guide.html So actually we need to use the dependency |
Hmmm |
Fix pushed, please approve if you are ok with that (also used |
Still failing |
Hmmm.. ok too fast:
@mdedetrich Any idea? |
Nope but it sounds like its a breaking change so maybe for 1.0.x series and lets try to update to latest sbt-site 1.4.x series? |
So I had a quick check and I think that sbt-site is not a dependency of this plugin but its rather used to update the project main website which is actually broken (see https://jonas.github.io/paradox-material-theme/). Which means it doesn't really matter when we fix it, Ill look into it a bit later |
Bad news is that sbt-site 1.4.x is not hosted on maven central also...
|
Well thats another one to add onto the list... |
It's broken because we migrated the repo from github.com/jonas to github.com/sbt. The website is now hosted under https://sbt.github.io/sbt-paradox-material-theme/. However, this redirects to https://www.scala-sbt.org/sbt-paradox-material-theme/, and I have now idea why... @eed3si9n Do you know why? |
sbt-site 1.5.x is hosted on maven central, so I think if we just find out what is causing the error (edit: and fix it 😉) we are good here. |
@mdedetrich fyi, I pushed a commit to make sure we don't pull in sbt-paradox > 0.9.2 unintentionally, because sbt-site-paradox does just that: https://github.com/sbt/sbt-site/blob/v1.5.0/build.sbt#L131-L136 |
Because sbt uses GitHub Pages with www.scala-sbt.org domain, all GitHub Pages under the sbt organization show up as a directory under it like https://www.scala-sbt.org/sbt-native-packager/. |
@mdedetrich fyi, I fixed this locally, will push tomorrow (need to clean up before, too tired now) |
Fixed, it works now. See the last two commits I pushed. Actually the sbt-site migration notes from 1.3.x -> 1.4.x gave the hints needed: https://www.scala-sbt.org/sbt-site/migration-guide.html#migrating-from-version-1-3-x-to-1-4-x So first commit I used the
The second commit I just moved the markdown file into
|
@mdedetrich I will go ahead and merge this, since I want to fix a sbt-web related problem. |
@mdedetrich Makes the test fail.