Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripted on GitHub Action #53

Closed
wants to merge 2 commits into from
Closed

Scripted on GitHub Action #53

wants to merge 2 commits into from

Conversation

eed3si9n
Copy link
Member

No description provided.

@eed3si9n eed3si9n requested review from mkurz and mdedetrich February 11, 2024 06:12
@@ -70,7 +70,6 @@ lazy val plugin = project("sbt-paradox-material-theme", file("plugin"))
addSbtPlugin("com.lightbend.paradox" % "sbt-paradox" % "0.4.4"),
libraryDependencies += "org.jsoup" % "jsoup" % "1.10.3",
libraryDependencies += "io.circe" %% "circe-core" % "0.9.3",
update := update.dependsOn(theme / publishLocal).value,
Copy link
Contributor

@mdedetrich mdedetrich Feb 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was put in deliberately because otherwise you cannot compile/update the project locally, see #45.

So I don't what to do here, it seems like a catch 22.

At least you found out what's causing the issue although I am still somewhat perplexed as to why this is screwing with the resolver in the CI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurz Does this help trigger your memories wrt #48 (comment) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can't remember. Great you solved this meanwhile 👍

Comment on lines +14 to +15
// this is to avoid triggering update, which will fail
Compile / compile := sbt.internal.inc.Analysis.empty,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdedetrich @mkurz Here's my hypothesis on the mysterious behavior. This build uses intertwined dependency pattern wherein the build itself uses the sbt plugin defined in the build, and specifically the root subproject enables ParadoxMaterialThemePlugin.

So while the root subproject does not contain any Scala source, compile will trigger an update at the root-level, which likely triggers the dependency resolution against theme version 0.6.0-SNAPSHOT, which doesn't exist yet. I don't know if the missing / is actually true, or some other red herring bug. In any case, the above demonstrates that short-circuiting the root Compile / compile fixes the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! I will update the original PR and give you credit for it

@mdedetrich
Copy link
Contributor

@eed3si9n Massive thanks for your help in diagnosing this, I have cleaned up the original PR at #48 as well as incorporating your fixes and giving you credit with Co-Authored-By, do you mind reviewing that PR and closing this one?

@eed3si9n eed3si9n closed this Feb 11, 2024
@eed3si9n eed3si9n deleted the wip/scripted branch February 11, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants