ssl_protocols,ciphers: Add a spec test and parameter documentation

sbadia · Jul 11, 2015 · 9215935 · 9215935
1 parent e15a392
commit 9215935
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -238,6 +238,14 @@
 #   SSL Key location
 #   default: /etc/ssl/private/ssl-cert-snakeoil.key
 #
+# [*gitlab_ssl_protocols*]
+#   Nginx SSL enabled protocols
+#   default: 'TLSv1.2 TLSv1.1 TLSv1'
+#
+# [*gitlab_ssl_ciphers*]
+#   Nginx SSL enabled ciphers
+#   default: 'AES:HIGH:!aNULL:!RC4:!MD5:!ADH:!MDF'
+#
 # [*gitlab_ssl_self_signed*]
 #   Set true if your SSL Cert is self signed
 #   default: false

diff --git a/spec/classes/gitlab_config_spec.rb b/spec/classes/gitlab_config_spec.rb
@@ -123,6 +123,8 @@
           it { is_expected.to contain_file('/etc/nginx/conf.d/gitlab.conf').with_content(/^\s*listen 443;$/)}
           it { is_expected.to contain_file('/etc/nginx/conf.d/gitlab.conf').with_content(/^\s*ssl_certificate               \/etc\/ssl\/certs\/ssl-cert-snakeoil.pem;$/)}
           it { is_expected.to contain_file('/etc/nginx/conf.d/gitlab.conf').with_content(/^\s*ssl_certificate_key           \/etc\/ssl\/private\/ssl-cert-snakeoil.key;$/)}
+          it { is_expected.to contain_file('/etc/nginx/conf.d/gitlab.conf').with_content(/^\s*ssl_protocols                 TLSv1.2 TLSv1.1 TLSv1;$/)}
+          it { is_expected.to contain_file('/etc/nginx/conf.d/gitlab.conf').with_content(/^\s*ssl_ciphers                   AES:HIGH:!aNULL:!RC4:!MD5:!ADH:!MDF;$/)}
           it { is_expected.to contain_file('/etc/nginx/conf.d/gitlab.conf').with_content(/^\s*proxy_set_header   X-Forwarded-Ssl   on;$/)}
         end
         ["hostname1", "hostname1 hostname2.example.com hostname3.example.org"].each do |domain_alias|