Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compile C source code as C++! #233

Merged

Conversation

saxbophone
Copy link
Owner

Libsxbp can't be compiled by a C++ compiler anyhow, but to make it abundantly clear that it shouldn't be, replace all

#ifdef __cplusplus
extern "C" {
#endif

blocks in non-header C source files with an error macro that is activated if __cplusplus is defined (and that the code is therefore being compiled with a C++ compiler).

I suppose I could just remove those macro sections completely, but seeing that I already have them in there, it could be nice to leave these explicit messages in there.

Closes #226

@saxbophone saxbophone merged commit 4fc20f6 into develop Dec 14, 2018
@saxbophone saxbophone deleted the josh/226-remove-ifdef-cplusplus-extern-c-in-c-sources branch December 14, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant