-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow implicit int to float conversion. #2887
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure this will help users a lot! I added some tests. It'd be nice to document that this cannot solve all situations.
@toots can I proceed with the merge? I think that you mentioned having some more comments... |
I think that some doc would be nice otherwise this is good to go on my end. |
Merge queue setting changed
@smimram do you still want to include that in |
This will allow users to use an int where a float is expected. For instance: