fix: status card

fix for bar chart Signed-off-by: saumeya <[email protected]> review comments Signed-off-by: saumeya <[email protected]>
saumeya · Dec 18, 2023 · b30a11d · b30a11d
1 parent 325b942
commit b30a11d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/src/components/pipelines-metrics/PipelinesAverageDuration.tsx b/src/components/pipelines-metrics/PipelinesAverageDuration.tsx
@@ -150,7 +150,7 @@ const PipelinesAverageDuration: React.FC<PipelinesAverageDurationProps> = ({
               }
               scale={{ x: 'time', y: 'linear' }}
               domain={domainValue}
-              domainPadding={{ x: [30, 25], y: [30, 25] }}
+              domainPadding={{ x: [30, 25]}}
               height={150}
               width={400}
               padding={{

diff --git a/src/components/pipelines-overview/PipelineRunsNumbersChart.tsx b/src/components/pipelines-overview/PipelineRunsNumbersChart.tsx
@@ -163,7 +163,7 @@ const PipelinesRunsNumbersChart: React.FC<PipelinesRunsNumbersChartProps> = ({
                 }
                 scale={{ x: 'time', y: 'linear' }}
                 domain={domainValue}
-                domainPadding={{ x: [30, 25], y: [30, 25] }}
+                domainPadding={{ x: [30, 25] }}
                 height={150}
                 padding={{
                   top: 20,

diff --git a/src/components/pipelines-overview/PipelineRunsStatusCard.tsx b/src/components/pipelines-overview/PipelineRunsStatusCard.tsx
@@ -21,9 +21,7 @@ import {
   CardTitle,
   Grid,
   GridItem,
-  Popover,
 } from '@patternfly/react-core';
-import { OutlinedQuestionCircleIcon } from '@patternfly/react-icons';
 import { chart_color_black_200 as othersColor } from '@patternfly/react-tokens/dist/js/chart_color_black_200';
 import { chart_color_black_500 as cancelledColor } from '@patternfly/react-tokens/dist/js/chart_color_black_500';
 import { chart_color_green_400 as successColor } from '@patternfly/react-tokens/dist/js/chart_color_green_400';
@@ -206,7 +204,7 @@ const PipelinesRunsStatusCard: React.FC<PipelinesRunsStatusCardProps> = ({
 
   const legendData = donutData.map((data) => {
     return {
-      name: `${data.x}: ${data.y}%`,
+      name: `${data.x}: ${isNaN(data.y) ? 0 : data.y}%`,
     };
   });
   return (
@@ -219,7 +217,8 @@ const PipelinesRunsStatusCard: React.FC<PipelinesRunsStatusCardProps> = ({
         <CardTitle className="pipeline-overview__pipelinerun-status-card__title">
           <span>
             {t('PipelineRun status')}{' '}
-            <Popover
+            {/* TODO - Add this tooltip after text content is finalized */}
+            {/* <Popover
               bodyContent={
                 <>
                   {t(
@@ -235,7 +234,7 @@ const PipelinesRunsStatusCard: React.FC<PipelinesRunsStatusCardProps> = ({
               >
                 <OutlinedQuestionCircleIcon />
               </span>
-            </Popover>
+            </Popover> */}
           </span>
         </CardTitle>
         <CardBody className="pipeline-overview__pipelinerun-status-card__title">