Merge pull request openshift-pipelines#30 from vikram-raj/ocpbugs-25334

OCPBUGS-25334: shows correct data on BarCharts
saumeya · Dec 13, 2023 · 57033bc · 57033bc
2 parents 00b6d71 + 4cc8bf4
commit 57033bc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/src/components/pipelines-overview/PipelineRunsNumbersChart.tsx b/src/components/pipelines-overview/PipelineRunsNumbersChart.tsx
@@ -93,14 +93,15 @@ const PipelinesRunsNumbersChart: React.FC<PipelinesRunsNumbersChartProps> = ({
   useInterval(getSummaryData, interval, namespace, date);
 
   const chartData = tickValues?.map((value) => {
+    const s = data?.summary.find((d) => {
+      return (
+        new Date(d.group_value * 1000).toDateString() ===
+        new Date(value).toDateString()
+      );
+    });
     return {
       x: value,
-      y: data?.summary.map((d) => {
-        return new Date(d.group_value * 1000).toDateString() ===
-          new Date(value).toDateString()
-          ? d.total
-          : 0;
-      })[0],
+      y: s?.total || 0,
     };
   });
 

diff --git a/src/components/pipelines-overview/PipelineRunsStatusCard.tsx b/src/components/pipelines-overview/PipelineRunsStatusCard.tsx
@@ -120,14 +120,15 @@ const PipelinesRunsStatusCard: React.FC<PipelinesRunsStatusCardProps> = ({
   const tickValues = getXaxisValues(timespan);
 
   const chartData = tickValues?.map((value) => {
+    const s = data2?.summary.find((d) => {
+      return (
+        new Date(d.group_value * 1000).toDateString() ===
+        new Date(value).toDateString()
+      );
+    });
     return {
       x: value,
-      y: data2?.summary.map((d) => {
-        return new Date(d.group_value * 1000).toDateString() ===
-          new Date(value).toDateString()
-          ? Math.round((100 * d.succeeded) / d.total)
-          : 0;
-      })[0],
+      y: Math.round((100 * s?.succeeded) / s?.total) || 0,
     };
   });