Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use node 22 #262

Merged
merged 11 commits into from
Jun 11, 2024
Merged

build: Use node 22 #262

merged 11 commits into from
Jun 11, 2024

Conversation

tianfeng92
Copy link
Contributor

Description

Use node 22.

@tianfeng92
Copy link
Contributor Author

tianfeng92 commented Jun 10, 2024

Note: The @cucumber/cucumber@v10 version is incompatible with our Playwright runner on the Windows platform (interestingly, this issue does not occur on Mac). I have downgraded it to v9 to resolve the issue.

Failed Windows test: https://app.saucelabs.com/tests/698f5ff6766c4d4985ec4fab46e9977a

Error: 
          You're calling functions (e.g. "Before") on an instance of Cucumber that isn't running (status: PENDING).
          This means you may have an invalid installation, potentially due to:
          - Cucumber being installed globally
          - A project structure where your support code is depending on a different instance of Cucumber
          Either way, you'll need to address this in order for Cucumber to work.
          See https://github.com/cucumber/cucumber-js/blob/main/docs/installation.md#invalid-installations

Tried the hint that cucumber provided by checking cucumber instance, but nothing interesting found. https://app.saucelabs.com/tests/541911eea91e4226bf817705e8da8dd6 Can do further investigation.

Executing pre-exec command: ..\node.exe node_modules\npm\bin\npm-cli.js why @cucumber/cucumber
@cucumber/[email protected]
node_modules/@cucumber/cucumber
  @cucumber/cucumber@"10.0.0" from the root project

Additionally, the recent failures in the last pipeline were due to issues with the runner download, not related to the above installation problem.

@tianfeng92 tianfeng92 marked this pull request as ready for review June 10, 2024 23:03
@tianfeng92 tianfeng92 requested a review from a team as a code owner June 10, 2024 23:03
@tianfeng92 tianfeng92 merged commit 1416420 into main Jun 11, 2024
23 of 29 checks passed
@tianfeng92 tianfeng92 deleted the DEVX-2897 branch June 11, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants