fix(modgrid): restore scroll position of modgrid after navigation #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the scroll position of the modgrid would be reset when a user navigated back to the grid page. This is due to the scrolling setup, where `div#page` is scrolled rather than the complete page. That could probably be properly fixed in the future, but this works for now.
|
@joshuata is attempting to deploy a commit to the satisfactorymodding Team on Vercel. A member of the Team first needs to authorize it. |
|
In the long term skeleton v3 is moving away from the AppShell to custom layouts for exactly this problem. So that is worth keeping an eye on for the future (https://next.skeleton.dev/docs/get-started/layouts) |
|
Pre-empted by #210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the scroll position of the modgrid would be reset when a user navigated back to the grid page. This is due to the scrolling setup, where
div#pageis scrolled rather than the complete page. That could probably be properly fixed in the future, but this works for now. Properly fixing this would likely resolve #156 and #183 as well.Fixes #42