-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fastTopics wrapper #151
base: master
Are you sure you want to change the base?
fastTopics wrapper #151
Conversation
… fixed the handling of the features (in particular, we avoid using VariableFeatures).
…oadings_fasttopics.
…er self contained.
Hi Seurat Developers, The paper describing these methods is now published in Genome Biology. Please let me know if I should update the fastTopics wrapper code to address any new requirements or compatibility issues with the latest version of Seurat. Thank you! |
Hi, now that Seurat 5 is released on CRAN, would now be a good time to revisit this pull request? Should I make sure that this wrapper is compatible with Seurat 5, and update it as needed? |
Just adding a +1 in support of Seurat5 support and +1 to Seurat Team in terms of merging into SeuratWrappers. @pcarbo in terms of updating to Seurat 5 it's pretty straightforward (from my brief testing). Only changes I had to make were:
Best, |
Dear Seurat Developers,
I'm submitting for your consideration a simple Seurat wrapper for the fastTopics package.
The most recent methods are described in a bioRxiv preprint.
I tried to follow the "contribution guide", but please let me know if you would like me to make any changes to the interface or implementation.
Thank you,
Peter