Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (IAC-1072) Add AKS pod cidr to LOADBALANCER_SOURCE_RANGES #496

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: (IAC-1072) Add AKS pod cidr to LOADBALANCER_SOURCE_RANGES #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions roles/common/tasks/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,16 @@
- tfstate.gke_pod_subnet_cidr is defined
- tfstate.gke_pod_subnet_cidr.value|length > 0
- (tfstate.gke_pod_subnet_cidr.value) not in LOADBALANCER_SOURCE_RANGES
- name: tfstate - Add AKS pod cidr to LOADBALANCER_SOURCE_RANGES # noqa: name[casing]
set_fact:
LOADBALANCER_SOURCE_RANGES: "{{ LOADBALANCER_SOURCE_RANGES + [tfstate.aks_pod_cidr.value] }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have a section for GKE and AWS. This again should be cluster_pod_subnet_cidr in the future and on line 50 above.

when:
- tfstate.provider is defined
- tfstate.provider.value|length > 0
- tfstate.provider.value == "azure"
- tfstate.aks_pod_cidr is defined
- tfstate.aks_pod_cidr.value|length > 0
- (tfstate.aks_pod_cidr.value) not in LOADBALANCER_SOURCE_RANGES
- name: tfstate - nfs endpoint # noqa: name[casing]
set_fact:
V4_CFG_RWX_FILESTORE_ENDPOINT: "{{ tfstate.rwx_filestore_endpoint.value }}"
Expand Down