This repository has been archived by the owner on Jun 26, 2018. It is now read-only.
Make GitHub ribbon clickable in small viewports #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #11 (please merge it first), so just look at 964b6f3 - the second commit.
At around 1240px wide the GitHub fork me ribbon div starts to slide under the LibSass logo and gradually becomes unclickable. I noticed this because I have my browser at half the screen width most of the time, and kept being taken back to libsass.com while clicking the ribbon.
The two obvious solutions to me are either to move the ribbon below the LibSass logo (thereby automatically placing the ribbon on top of the LibSass logo), or to add
z-index:1to the style attribute of the image. I chose the first option because I think that the LibSass logo should come first anyway (after all, the project page is about LibSass), but I can change it to thez-indexoption instead if preferred.