Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu compatibility #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

RobinReborn
Copy link

Will now work with Ubuntu - had to change ping expected response and also catch error in record reading.

Please forgive any Ruby errors I've made

@sarahemm
Copy link
Owner

sarahemm commented Apr 1, 2020

Do you know why the ping response your unit gives is different, offhand? If I change this it's not going to work with mine anymore since mine gives 0x00 in that field whereas yours seems to give 0x01. I'll look into it a bit more if you're not sure and see if maybe that's a hardware version or something, I can just mask off that one byte so it will accept anything there if it's something like that.

@RobinReborn
Copy link
Author

I don't - it could be that we're using slightly different models. I tried to write it so that it will try one, and if that fails try the other.

@sarahemm
Copy link
Owner

sarahemm commented Apr 3, 2020

I'll take a look and merge over the weekend, thanks for the PR! Out of curiosity, does your PF100 use a standard USB connector or a proprietary one? Mine is the latter, but I've seen a friend's which has Mini USB on it, just curious if there's a different hardware revision in play here.

@RobinReborn
Copy link
Author

I have a standard USB - that could be the issue.

@sarahemm
Copy link
Owner

sarahemm commented Apr 26, 2020

This is still on my radar, just haven't had time or brainspace to look it over yet with work being intense the last few weeks. Apologies for the delay, hoping to get to it soon!

@RobinReborn
Copy link
Author

OK - let me know I've done some other work and want to integrate it more closely with my own project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants