Skip to content

Commit

Permalink
[pxc-db] Add prometheus scrape annotations to backup jobs and deploym…
Browse files Browse the repository at this point in the history
…ents

Add prometheus scrape labels to backup jobs and deployments
This will enable metrics scraping for binlog-collector deployments
  • Loading branch information
s10 committed Dec 23, 2024
1 parent 197c1c7 commit d3644bb
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion common/pxc-db/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.0
version: 0.2.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion common/pxc-db/templates/cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ spec:
s3-backups-{{ $storage }}:
type: s3
annotations:
{{ merge (include "pxc-db.linkerdPodAnnotations" $ | fromYaml) ($backup.annotations) | toYaml | indent 10 }}
{{ merge (include "pxc-db.linkerdPodAnnotations" $ | fromYaml) (include "pxc-db.metricsAnnotations" $ | fromYaml) ($backup.annotations) | toYaml | indent 10 }}
labels:
{{ merge (include "pxc-db.backupLabels" $ | fromYaml) ($backup.labels) | toYaml | indent 10 }}
resources:
Expand Down
1 change: 0 additions & 1 deletion common/pxc-db/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ backup:
limits: {}
pitr:
enabled: false
annotations: {}
storageName: s3-backups-binlogs
timeBetweenUploads: 300
timeoutSeconds: 60
Expand Down

0 comments on commit d3644bb

Please sign in to comment.