add additional linter & dotimportwhitelist #115
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of projects I am working on use Ginkgo and Gomega for writing tests.
Usually Ginkgo and Gomega are dot imported, which is flagged by the
stylecheck
linter.So I have to manually exclude the paths for these two libs in the
.golangci.yaml
:Also I am enabling the
ginkgolinter
, which provides some valuable suggestions for the usage of ginkgo.I would like to be able to specify this in the
Makefile.maker.yaml
, as currently I have to remember to re-add these configurations after runninggo-makefile-maker
.Since not every Go project is using these two libraries for testing, I was hesitant to add the configuration as a default to the
.golangci.yaml
template.Another option I considered was adding a ginkgo/gomega specific option to the config to add these configurations if that option is set. But this would be very specific and the individual flags allow others use-cases as well.