Parameterize absent pr name #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 20, 2023 13:53
…r -rule "{{ .Namespace }}-{{ .Name }}-absent-metrics"
…r -rule "{{ .metadata.namespace }}-{{ .metadata.name }}-absent-metrics" 2>&1
conallprendergast
force-pushed
the
Parameterize-Absent-PR-Name
branch
from
ba33b18 to
6b88aa2
Compare
majewsky
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Sorry for the late response. I am currently quite busy, but I will try to have one of my teammates look at this soon. As a quick note, can you please run gofmt to clean up the formatting? The easiest way to do this would be through golangci-lint, i.e. make prepare-static-check && golangci-lint run --fix.
Comment on lines
+277
to
+278
| promServer = "default-prometheus" | ||
| // return errors.New("no 'prometheus' label found") |
There was a problem hiding this comment.
This looks like some leftover debugging code
| buf := &bytes.Buffer{} | ||
| err = t.Execute(buf, m) | ||
| if err != nil { | ||
| fmt.Println(err.Error()) |
There was a problem hiding this comment.
Please use the standard logging methods used elsewhere in the program
|
Since we wouldn't be using this feature in our environment, can you add a test case which would fail when executed on the code on master, to prevent that the feature regresses in the future? Also please make sure that static-check is not failing. Right now the existing test suite is failing to compile because one function takes extra arguments. |
talal
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Patch metrics operatr to work with a hack
* Working with ./build/absent-metrics-operator -keep-labels service,tier -rule "{{ .Namespace }}-{{ .Name }}-absent-metrics"
* Working with ./build/absent-metrics-operator -keep-labels service,tier -rule "{{ .metadata.namespace }}-{{ .metadata.name }}-absent-metrics" 2>&1
* Clean up
---------
Co-authored-by: Conall Prendergast <[email protected]>
talal
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Patch metrics operatr to work with a hack
* Working with ./build/absent-metrics-operator -keep-labels service,tier -rule "{{ .Namespace }}-{{ .Name }}-absent-metrics"
* Working with ./build/absent-metrics-operator -keep-labels service,tier -rule "{{ .metadata.namespace }}-{{ .metadata.name }}-absent-metrics" 2>&1
* Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
-ruleflag that takes a go template, allowing configuration of the generated absence PrometheusRule API object.eg