sap_install_media_detect: Fix wrong sap_export_solman_java detection #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #921. The SAP Solution Manager JAVA Export file (e.g. 51054655_4.zip) contains files with the search pattern for 'sap_export_nwas_java' before files with the search pattern for 'sap_export_solman_java'. So we fall through (= do no longer exit) for the search pattern of the SAP Netweaver Java files (e.g. 51055106.zip). This will work as long as such files do not have content which are matched by any other search pattern. Tested with: 51050829_3 (NW 7.5 Installation Export) 51054655_1 (SAP Solution Manager 7.2 SR2 Installation Export I) 51054655_2 (SAP Solution Manager 7.2 SR2 Installation Export II) 51054655_4 (SAP Solution Manager 7.2 SR2 - Java) 51055106 (SAP Netweaver 7.5 SP22 Java) $ sapfile *.zip 51050829_3.zip: sap_export_nwas_abap 51054655_1.zip: sap_export_solman_abap 51054655_2.zip: sap_export_solman_abap 51054655_4.zip: sap_export_solman_java 51055106.zip: sap_export_nwas_java Signed-off-by: Bernd Finger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #912.
The SAP Solution Manager JAVA Export file (e.g. 51054655_4.zip) contains files with the search pattern for 'sap_export_nwas_java' before files with the search pattern for 'sap_export_solman_java'. So we do no longer exit for the search pattern of the SAP Netweaver Java files (e.g. 51055106.zip). This will work as long as such files do not have content which are matched by any other search pattern.
Tested with:
51050829_3(NW 7.5 Installation Export)51054655_1(SAP Solution Manager 7.2 SR2 Installation Export I)51054655_2(SAP Solution Manager 7.2 SR2 Installation Export II)51054655_4(SAP Solution Manager 7.2 SR2 - Java)51055106(SAP Netweaver 7.5 SP22 Java)