Add redhat_ocp_virt platform to sap_hypervisor_node_preconfigure #468

newkit · 2023-09-22T06:06:24Z

This PR adds functionality to configure an OCP cluster for SAP workloads.

…o dev

playbooks/vars/sample-variables-sap-hypervisor-node-preconfigure-rh_ocp_virt.yml

roles/sap_hypervisor_node_preconfigure/README.md

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_rhel_kvm/assert-configuration.yml

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_rhel_kvm/configuration.yml

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/configure-worker-node.yml

Co-authored-by: Felix Matouschek <[email protected]>

…o dev

…atform/redhat_ocp_virt/sriov-enabled-unsupported-nics.sh

This reverts commit 724e1ad.

sean-freeman · 2023-11-23T11:51:34Z

@newkit @0xFelix Is this PR complete? If not then please click convert to draft which is listed in the right sidebar under 'Reviewers'.

Klaas- · 2023-11-23T13:09:59Z

OCP is unsupported by SAP, right? We still had some hope for the certification to happen but I was told last week it's off the table and will never be discussed again (by SAP).

newkit · 2023-11-23T15:44:40Z

@newkit @0xFelix Is this PR complete? If not then please click convert to draft which is listed in the right sidebar under 'Reviewers'.

I'm done with the OCP part which I am focusing on ATM. Will address the RHV comments later.

newkit · 2023-11-23T15:46:57Z

OCP is unsupported by SAP, right? We still had some hope for the certification to happen but I was told last week it's off the table and will never be discussed again (by SAP).

Well, I'd say never say never, but you are right, ATM it does not look like there will be a validation/support from SAP for customers to run this on-prem. Still we hope to enable and encourage ppl to use this for testing and developing purposes.

sean-freeman · 2023-11-24T11:08:56Z

@newkit please acknowledge this PR is ready for final review and merge; there have been too many commits appended since the PR was created and we need confirmation before merge.

@Klaas- draw your own conclusion from the following personal points of view.... in Android upstream source code new device codenames are always visible and reported on news websites + any support circumstance can be negotiated if a software vendor wants to make a deal with a customer.

sean-freeman · 2023-12-05T12:35:39Z

@newkit please acknowledge this PR is ready for final review and merge; there have been too many commits appended since the PR was created and we need confirmation before merge.

I still see 51 review comments ('Resolve Conversation' buttons) that have not be marked as resolved.

…mplate rendering and usage in one go for HPs

newkit

Review done, not all proposals could be addressed now but are in backlog, e.g. remove static waits.

sean-freeman

lgtm 👍

0xFelix

Added some comments. IMO not all previous comments have been addressed but unfortunately this was merged already. Can you please create issues to track the follow up work?

roles/sap_hypervisor_node_preconfigure/README.md

0xFelix · 2023-12-12T10:49:28Z

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/configure-worker-node.yml

+#- name: Label the node with cpumanager=true
+#  ansible.builtin.k8s:
+#    definition:
+#      apiVersion: v1
+#      kind: Node
+#      metadata:
+#        name: "{{ __sap_hypervisor_node_preconfigure_register_worker.name }}"
+#        labels:
+#          cpumanager: true
+#    state: present
+#
+#- name: Label the node with invtsc=true
+#  ansible.builtin.k8s:
+#    definition:
+#      apiVersion: v1
+#      kind: Node
+#      metadata:
+#        name: "{{ __sap_hypervisor_node_preconfigure_register_worker.name }}"
+#        labels:
+#          invtsc: true
+#    state: present


These tasks are commented out.

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/install-cnv-operator.yml

...sap_hypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/install-nmstate-operator.yml

0xFelix · 2023-12-12T11:01:11Z

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/setup-worker-nodes.yml

+- name: Render template
+  ansible.builtin.template:
+    src: 99-kargs-worker.yml.j2
+    dest: "{{ __sap_hypervisor_node_preconfigure_register_tmpdir.path }}/99-kargs-worker.yml"
+    mode: "0644"
+
+- name: Enable hugepages
+  kubernetes.core.k8s:
+    state: present
+    src: "{{ __sap_hypervisor_node_preconfigure_register_tmpdir.path }}/99-kargs-worker.yml"


...ypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/sriov-enabled-unsupported-nics.sh

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_rhel_kvm/assert-configuration.yml

Nils Koenig and others added 5 commits September 26, 2023 13:54

added redhat_ocp_virt platform to sap_hypervisor_node_preconfigure

3d4ae5b

Merge branch 'sap-linuxlab:dev' into dev

0cb059a

Merge branch 'sap-linuxlab:dev' into dev

4a8f670

Merge branch 'dev' of github.com:newkitlabs/community.sap_install int…

82ac5dc

…o dev

updated documentation

d455bbc

0xFelix reviewed Oct 18, 2023

View reviewed changes

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/configure-worker-node.yml Outdated Show resolved Hide resolved

newkit and others added 23 commits October 24, 2023 15:50

Update roles/sap_hypervisor_node_preconfigure/README.md

5600c6e

Co-authored-by: Felix Matouschek <[email protected]>

Update roles/sap_hypervisor_node_preconfigure/README.md

0e1ce92

Co-authored-by: Felix Matouschek <[email protected]>

include hpp

8c80b9e

added install-hpp.yml

68f775d

Merge branch 'hpp' into dev

f4fd42e

Update roles/sap_hypervisor_node_preconfigure/README.md

b743620

Co-authored-by: Felix Matouschek <[email protected]>

Merge branch 'dev' of github.com:newkitlabs/community.sap_install int…

af869ef

…o dev

updated doc

8ac014c

WIP: restructure sap_hypervisor_node_preconfigure

1000071

variable name fix (minor)

2edc92a

fixed missing vars

34a8dca

removed unnecessary files

ec5b083

added label cpumanager

4afbe84

fixed worker node name when labeling for cpumanger

1bf351b

removed misplaced kubernetes_reserved_cpu

288b76f

added info on required dependencies

ea875e6

implemented ansible-lint suggestions

ce45a58

removed obsolete file roles/sap_hypervisor_node_preconfigure/files/pl…

a98efd5

…atform/redhat_ocp_virt/sriov-enabled-unsupported-nics.sh

renamed setup-worker-node -> setup-worker-nodes

fe45274

Merge branch 'sap-linuxlab:dev' into dev

f40c0ea

updated README.md; name template.yml after instanciation

8ecce64

removed startup dependency for HPP

62d34b8

fixed creation of cpumanager KR

37440c1

Nils Koenig added 4 commits November 13, 2023 13:11

updated docu

3ca31d5

include defaults platform dependent

724e1ad

Revert "include defaults platform dependent"

860f712

This reverts commit 724e1ad.

Revert "include defaults platform dependent"

ae4456a

This reverts commit 724e1ad.

berndfinger changed the title ~~added redhat_ocp_virt platform to sap_hypervisor_node_preconfigure~~ Add redhat_ocp_virt platform to sap_hypervisor_node_preconfigure Nov 16, 2023

Nils Koenig added 5 commits November 16, 2023 16:27

create VM namespace, remove uneeded waits

ce82be3

fixed merge conflict

8308ccc

fixed typo

1db86b8

added missing whitespace before linebreak

dbc634f

fixed typo and indentation

24ccfa7

Nils Koenig added 8 commits December 6, 2023 11:16

Ansible lint wants role name to start with a capital letter

bc4a43c

Made clear that memory unit used is GiB

a89f7da

fixed memory variable renaming and removed cating to int

a0410b6

cast integers when used

88adb96

label nodes via k8s

7a94e65

labeling did not work

b225ee9

reverted not working PR suggestions: booleans in trident template; te…

53be961

…mplate rendering and usage in one go for HPs

use kubernetes.core.k8s rather than ansible k8s module

b072cb5

newkit commented Dec 11, 2023

View reviewed changes

sean-freeman approved these changes Dec 11, 2023

View reviewed changes

sean-freeman merged commit 0aa151d into sap-linuxlab:dev Dec 11, 2023
2 checks passed

0xFelix reviewed Dec 12, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add redhat_ocp_virt platform to sap_hypervisor_node_preconfigure #468

Add redhat_ocp_virt platform to sap_hypervisor_node_preconfigure #468

newkit commented Sep 22, 2023

sean-freeman commented Nov 23, 2023

Klaas- commented Nov 23, 2023

newkit commented Nov 23, 2023

newkit commented Nov 23, 2023

sean-freeman commented Nov 24, 2023

sean-freeman commented Dec 5, 2023

newkit left a comment

sean-freeman left a comment

0xFelix left a comment

0xFelix Dec 12, 2023

0xFelix Dec 12, 2023

Add redhat_ocp_virt platform to sap_hypervisor_node_preconfigure #468

Add redhat_ocp_virt platform to sap_hypervisor_node_preconfigure #468

Conversation

newkit commented Sep 22, 2023

sean-freeman commented Nov 23, 2023

Klaas- commented Nov 23, 2023

newkit commented Nov 23, 2023

newkit commented Nov 23, 2023

sean-freeman commented Nov 24, 2023

sean-freeman commented Dec 5, 2023

newkit left a comment

Choose a reason for hiding this comment

sean-freeman left a comment

Choose a reason for hiding this comment

0xFelix left a comment

Choose a reason for hiding this comment

0xFelix Dec 12, 2023

Choose a reason for hiding this comment

0xFelix Dec 12, 2023

Choose a reason for hiding this comment