Skip to content

Commit

Permalink
Merge pull request #594 from berndfinger/issue-593
Browse files Browse the repository at this point in the history
collection: Rearrange the comments in all .ansible-lint files
  • Loading branch information
ja9fuchs authored Jan 12, 2024
2 parents 884c772 + 2ce2a04 commit ee3a84c
Show file tree
Hide file tree
Showing 15 changed files with 153 additions and 59 deletions.
14 changes: 9 additions & 5 deletions .ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,16 @@ exclude_paths:
#- roles/sap_swpm
- roles/sap_vm_preconfigure
- tests/

enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
15 changes: 12 additions & 3 deletions roles/sap_anydb_install_oracle/.ansible-lint
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
---
exclude_paths:
- tests/
enable_list:
- yaml
skip_list:
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_general_preconfigure/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_ha_install_hana_hsr/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_ha_pacemaker_cluster/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_hana_install/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_hana_preconfigure/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_hostagent/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_hypervisor_node_preconfigure/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_install_media_detect/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_maintain_etc_hosts/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_netweaver_preconfigure/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_storage_setup/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
14 changes: 10 additions & 4 deletions roles/sap_swpm/.ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ exclude_paths:
enable_list:
- yaml
skip_list:
- meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]
15 changes: 12 additions & 3 deletions roles/sap_vm_preconfigure/.ansible-lint
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
---
exclude_paths:
- tests/
enable_list:
- yaml
skip_list:
- ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
- schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
- name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
# We don't want to enforce new Ansible versions for Galaxy:
- meta-runtime[unsupported-version]
# We do not want to use checks which are marked as experimental:
- experimental
# We use ignore_errors for all the assert tasks, which should be acceptable:
- ignore-errors
# We want to allow single digit version numbers in a role's meta/main.yml file:
- schema
# Allow templating inside name because it creates more detailed output:
- name[template]

0 comments on commit ee3a84c

Please sign in to comment.