Merge pull request #604 from sap-linuxlab/dev

collection: merge dev to main for release 1.3.4

.ansible-lint

@@ -15,16 +15,22 @@ exclude_paths:
   #- roles/sap_hana_preconfigure
   - roles/sap_hostagent
   - roles/sap_hypervisor_node_preconfigure
-  - roles/sap_install_media_detect
+  #- roles/sap_install_media_detect
   #- roles/sap_netweaver_preconfigure
   #- roles/sap_storage_setup
   #- roles/sap_swpm
   - roles/sap_vm_preconfigure
-
+  - tests/
 enable_list:
   - yaml
 skip_list:
+  # We don't want to enforce new Ansible versions for Galaxy:
+  - meta-runtime[unsupported-version]
+  # We do not want to use checks which are marked as experimental:
   - experimental
-  - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable
-  - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6.
-  - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work
+  # We use ignore_errors for all the assert tasks, which should be acceptable:
+  - ignore-errors
+  # We want to allow single digit version numbers in a role's meta/main.yml file:
+  - schema
+  # Allow templating inside name because it creates more detailed output:
+  - name[template]

.github/workflows/ansible-lint-sap_install_media_detect.yml

@@ -0,0 +1,43 @@
+---
+
+# Workflow for ansible-lint of a role
+
+name: ansible-lint of the role sap_install_media_detect
+
+on:
+  push:
+    branches:
+      - main
+      - dev
+    paths:
+      - 'roles/sap_install_media_detect/**'
+  pull_request:
+    branches:
+      - main
+      - dev
+    paths:
+      - 'roles/sap_install_media_detect/**'
+
+jobs:
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out the code
+        uses: actions/checkout@main
+
+      - name: Set up Python 3
+        uses: actions/setup-python@main
+        with:
+          python-version: '3.9'
+
+      - name: Install test dependencies
+        run: |
+          pip3 install ansible==7.5.0
+          pip3 install ansible-compat==3.0.2
+          pip3 install ansible-core==2.14.5
+          pip3 install ansible-lint==6.8.6
+
+      - name: Run ansible-lint
+        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_install_media_detect
+        run: ansible-lint

.github/workflows/ansible-lint-sap_maintain_etc_hosts.yml

@@ -0,0 +1,43 @@
+---
+
+# Workflow for ansible-lint of a role
+
+name: ansible-lint of the role sap_maintain_etc_hosts
+
+on:
+  push:
+    branches:
+      - main
+      - dev
+    paths:
+      - 'roles/sap_maintain_etc_hosts/**'
+  pull_request:
+    branches:
+      - main
+      - dev
+    paths:
+      - 'roles/sap_maintain_etc_hosts/**'
+
+jobs:
+  ansible-lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out the code
+        uses: actions/checkout@main
+
+      - name: Set up Python 3
+        uses: actions/setup-python@main
+        with:
+          python-version: '3.9'
+
+      - name: Install test dependencies
+        run: |
+          pip3 install ansible==7.5.0
+          pip3 install ansible-compat==3.0.2
+          pip3 install ansible-core==2.14.5
+          pip3 install ansible-lint==6.8.6
+
+      - name: Run ansible-lint
+        working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_maintain_etc_hosts
+        run: ansible-lint

.github/workflows/ansible-lint-sap_vm_preconfigure.yml

@@ -29,14 +29,14 @@ jobs:
       - name: Set up Python 3
         uses: actions/setup-python@main
         with:
-          python-version: '3.9'
+          python-version: '3.12'
 
       - name: Install test dependencies
         run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
+          pip3 install ansible==9.1.0
+          pip3 install ansible-compat==4.1.10
+          pip3 install ansible-core==2.16.2
+          pip3 install ansible-lint==6.22.1
 
       - name: Run ansible-lint
         working-directory: /home/runner/work/community.sap_install/community.sap_install/roles/sap_vm_preconfigure

.github/workflows/ansible-lint.yml

@@ -21,14 +21,14 @@ jobs:
       - name: Set up Python 3
         uses: actions/setup-python@main
         with:
-          python-version: '3.9'
+          python-version: '3.12'
 
       - name: Install test dependencies
         run: |
-          pip3 install ansible==7.5.0
-          pip3 install ansible-compat==3.0.2
-          pip3 install ansible-core==2.14.5
-          pip3 install ansible-lint==6.8.6
+          pip3 install ansible==9.1.0
+          pip3 install ansible-compat==4.1.10
+          pip3 install ansible-core==2.16.2
+          pip3 install ansible-lint==6.22.1
 
 #      - name: Install collection dependencies
 #        run: ansible-galaxy collection install community.general

.github/workflows/codespell.yml

@@ -0,0 +1,20 @@
+name: CodeSpell
+
+on:
+  push:
+    branches:
+      - dev
+  pull_request:
+    branches:
+      - dev
+
+jobs:
+  codespell:
+    name: Check for spelling errors
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+      - uses: codespell-project/actions-codespell@master
+        with:
+          ignore_words_list: aas,hsa,te,chage,addopt,sybsystem,uptodate

.pre-commit-config.yaml

@@ -33,7 +33,7 @@ repos:
             #      types: [file, yaml]
             #      entry: yamllint --strict
   - repo: https://github.com/ansible-community/ansible-lint.git
-    rev: v6.8.6  # put latest release tag from https://github.com/ansible-community/ansible-lint/releases/
+    rev: v6.22.1  # put latest release tag from https://github.com/ansible-community/ansible-lint/releases/
     hooks:
       - id: ansible-lint
         files: \.(yaml|yml)$

CHANGELOG.rst

@@ -5,6 +5,30 @@ community.sap_install Release Notes
 .. contents:: Topics
 
 
+v1.3.4
+======
+
+Release Summary
+---------------
+
+| Release Date: 2024-01-15
+| collection: Feature add for CodeSpell in git repository
+| collection: Bug fix for ansible-lint of each Ansible Role within Ansible Collection
+| collection: Bug Fix for Ansible Core minimum version update to 2.12.0 for import compliance with Ansible Galaxy
+| collection: Bug Fix for Ansible CVE-2023-5764
+| sap_general_preconfigure: Feature add for additional RHEL for SAP 8.8 and 9.2 release compatibility
+| sap_hana_preconfigure: Feature add for compatibility with SLES using sapconf and SLES for SAP using saptune
+| sap_hana_preconfigure: Feature add for additional RHEL for SAP 8.8 and 9.2 release compatibility
+| sap_hana_preconfigure: Feature add to reduce restrictions on new OS versions which are not yet supported by SAP
+| sap_netweaver_preconfigure: Feature add for compatibility with SLES using sapconf and SLES for SAP using saptune
+| sap_ha_pacemaker_cluster: Feature add for Virtual IP and Constraints logic with Cloud Hyperscaler vendors
+| sap_hypervisor_node_preconfigure: Feature add for preconfiguration of KubeVirt (OpenShift Virtualization) hypervisor nodes
+| sap_hypervisor_node_preconfigure: Bug fix for preconfiguration code structure of KVM (Red Hat Enterprise Virtualization) hypervisor nodes
+| sap_install_media_detect: Bug Fix for existing files
+| sap_maintain_etc_hosts: Feature add for maintaining the /etc/hosts file of an SAP software host
+| sap_swpm: Bug fix for runtime missing dependency python3-pip and advanced execution mode skipped tasks during certain installations
+| sap_swpm: Feature add for basic System Copy executions in default mode
+
 v1.3.3
 ======