Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR-IOV : Include resource creation for SriovOperatorConfig & replace pause with conditional checks #62

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

geetikakay
Copy link
Contributor

This PR handles:

  1. SriovOperatorConfig resource creation as it is not available in upcoming k8s versions.
  2. remove pause and replace with conditional checks

This PR is tested before submitting

@geetikakay
Copy link
Contributor Author

@newkit hello, Please review. This fixes : https://issues.redhat.com/browse/CNV-47404

@newkit newkit self-requested a review September 24, 2024 10:05
@newkit
Copy link
Contributor

newkit commented Sep 24, 2024

Hi @geetikakay, could you please add the role name to the commit message in the beginning? Thanks!

…OperatorConfig & replace pause with conditional checks

Signed-off-by: Geetika Kapoor <[email protected]>
Copy link
Contributor

@newkit newkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@newkit newkit merged commit 24f132c into sap-linuxlab:dev Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants